~steering/inspircd++.git/include/inspircd.h, branch v3.0.0a6 Unnamed repository; edit this file 'description' to name the repository. https://www.cgit.space/~steering/inspircd++.git/atom/include/inspircd.h?h=v3.0.0a6 2018-01-14T18:07:05Z Fix some minor Doxygen errors. 2018-01-14T18:07:05Z Peter Powell 2018-01-14T18:07:05Z urn:sha1:51206352a965aced6913957f80421ade6ebe1eb3 Rework message handling. 2018-01-06T14:18:21Z Peter Powell 2017-12-11T19:42:52Z urn:sha1:2fcb5ff4389a9a82d253acdff02a388ddcf14653 - Move all message-related types to their own header to make moving them to a cross-module events easier. - Rename OnUserMessage to OnUserPostMessage. - Rename OnText to OnUserMessage. - Replace the dest, target_type, and status parameters with the MessageTarget class. - Replace the text, exempt_list, and msgtype parameters with the MessageDetails struct. - Add echooriginal and originaltext to the MessageDetails struct to allow spam filtering to not be broken by cap echo-message. Make InspIRCd::Format return std::string instead of const char*. 2018-01-03T12:38:40Z Peter Powell 2018-01-01T23:56:35Z urn:sha1:372bb6ec31e26908966ff553b782c9a24a07db6a Using the latter is problematic as if you don't copy the return value before calling Format again your formatted message will be overwritten by something else. This bug was observed in m_callerid where InspIRCd::Format was being used for formatting two arguments the latter of which was being overwritten with the former. We could have preserved the return type and just copied the string but then callers would have had to deallocate the string once they have finished with it which is an undesirabable burden to put on callers. Get rid of InspIRCd::QuickExit. 2017-12-23T12:13:06Z Peter Powell 2017-12-10T13:48:57Z urn:sha1:57330e973b3eb1f2a84803c84daf9d6b420859fd This is just a thin wrapper around exit(). I don't think we really need it. While we are changing this code the setgroup/setuser code should be using EXIT_STATUS_CONFIG too. Convert the remaining things away from the caller/handler API. 2017-11-25T13:38:02Z Peter Powell 2017-11-25T13:01:53Z urn:sha1:fa95bb4b0d5aed9204d469a36946a9839a7ffaa2 Convert GenRandom to std::function. 2017-11-25T13:38:02Z Peter Powell 2017-11-25T12:50:11Z urn:sha1:6abc789577a86ffcdce8fae81b37f825d9ca4226 Convert IsChannel to std::function. 2017-11-25T13:38:02Z Peter Powell 2017-11-25T12:37:48Z urn:sha1:1dca8b79edf65c0e5e846cc120f1321fb0a1d15c Convert IsIdent to std::function. 2017-11-25T13:38:02Z Peter Powell 2017-11-25T12:29:05Z urn:sha1:3b3cb845602bbaa3935f736785a53724750230dc Convert IsNick to std::function. 2017-11-25T13:38:02Z Peter Powell 2017-11-25T12:15:35Z urn:sha1:7ece928bab20881d6fe24c4479f4ff9e0a8a7179 Add the override keyword in places that it is missing. 2017-11-21T15:51:45Z Peter Powell 2017-11-21T13:05:17Z urn:sha1:91e0af0fc4889f20d2f63426f8fe379674fc0393 GCCs warnings for this are much better than Clangs.