Fix various edge cases in extensible synchronisation.

- Fix not forwarding the accountid extensible if it is set.
- Rename the variadic Set() overload to SetFwd().
- Re-add the `const T&` overload of Set().
- Move `bool synced` to SimpleExtItem from StringExtItem.
- Only sync extensibles if their instance is marked as syncable.

1 files changed, 3 insertions, 4 deletions

diff --git a/src/extensible.cpp b/src/extensible.cpp
index 641d62337..1e02fc526 100644
--- a/src/extensible.cpp
+++ b/src/extensible.cpp
@@ -232,14 +232,14 @@ bool BoolExtItem::Get(const Extensible* container) const
 void BoolExtItem::Set(Extensible* container, bool sync)
 {
 	SetRaw(container, reinterpret_cast<void*>(1));
-	if (sync)
+	if (sync && synced)
 		Sync(container, reinterpret_cast<void*>(1));
 }
 
 void BoolExtItem::Unset(Extensible* container, bool sync)
 {
 	UnsetRaw(container);
-	if (sync)
+	if (sync && synced)
 		Sync(container, reinterpret_cast<void*>(0));
 }
 
@@ -299,8 +299,7 @@ void IntExtItem::Unset(Extensible* container, bool sync)
 }
 
 StringExtItem::StringExtItem(Module* owner, const std::string& key, ExtensionType exttype, bool sync)
-	: SimpleExtItem(owner, key, exttype)
-	, synced(sync)
+	: SimpleExtItem(owner, key, exttype, sync)
 {
 }