diff options
| author |  Sadie Powell | 2024-08-27 16:20:49 +0100 |
|---|---|---|
| committer | Sadie Powell | 2024-08-27 16:31:38 +0100 |
| commit | 3f7a7df7409e177f158bdd677321e4a61eb6a440 (patch) | |
| tree | c0aa2641655d40fb497007f5c705e40a072f87a4 /src/modules/extra | |
| parent | Use GenRandom instead of GenRandomInt to populate Bcrypt entropy. (diff) | |
Deprecate the raw overload of GenRandomStr in favour of GenRandom.
The raw overload was almost always misused where GenRandom would
be better.
While we're making changes to this code switch the printable mode
to use a static array like Anope does.
Diffstat (limited to 'src/modules/extra')
| -rw-r--r-- | src/modules/extra/m_argon2.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/modules/extra/m_argon2.cpp b/src/modules/extra/m_argon2.cpp index 30d3de06b..999bd7d82 100644 --- a/src/modules/extra/m_argon2.cpp +++ b/src/modules/extra/m_argon2.cpp @@ -92,7 +92,8 @@ public: std::string GenerateRaw(const std::string& data) override { - const std::string salt = ServerInstance->GenRandomStr(config.saltlen, false); + std::vector<char> salt(config.saltlen); + ServerInstance->GenRandom(salt.data(), salt.size()); size_t encodedLen = argon2_encodedlen( config.iterations, @@ -111,8 +112,8 @@ public: config.threads, data.c_str(), data.length(), - salt.c_str(), - salt.length(), + salt.data(), + salt.size(), raw_data.data(), raw_data.size(), encoded_data.data(), |