diff options
| author |  Peter Powell | 2018-01-27 13:05:14 +0000 |
|---|---|---|
| committer | Peter Powell | 2018-01-29 11:52:13 +0000 |
| commit | d5a6054948502625d7f0c235f6faaeea58734de5 (patch) | |
| tree | a43e95ded07dca92c9d3659e331a88cb8e0b7b21 /src/modules/m_kicknorejoin.cpp | |
| parent | Improve performance under load of OnDataReady and remove C-isms. (diff) | |
Add ERR_INVALIDMODEPARAM for responding to invalid mode params.
Currently on invalid modes we do a combination of different things:
1. Send a custom mode-specific numeric (which often collides with
other modes).
2. Send a server notice.
3. Do absolutely nothing.
This new numeric is a generic way of handling invalid parameters
when setting a mode that avoids all of the mistakes of the previous
behaviour.
Diffstat (limited to 'src/modules/m_kicknorejoin.cpp')
| -rw-r--r-- | src/modules/m_kicknorejoin.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/modules/m_kicknorejoin.cpp b/src/modules/m_kicknorejoin.cpp index 1bc11948c..67711f766 100644 --- a/src/modules/m_kicknorejoin.cpp +++ b/src/modules/m_kicknorejoin.cpp @@ -95,7 +95,10 @@ class KickRejoin : public ParamMode<KickRejoin, SimpleExtItem<KickRejoinData> > { int v = ConvToInt(parameter); if (v <= 0) + { + source->WriteNumeric(Numerics::InvalidModeParameter(channel, this, parameter)); return MODEACTION_DENY; + } if ((IS_LOCAL(source) && ((unsigned int)v > max))) v = max; |