aboutsummaryrefslogtreecommitdiff
path: root/src/modules/m_vhost.cpp
diff options
context:
space:
mode:
authorGravatar Sadie Powell2020-03-11 14:32:46 +0000
committerGravatar Sadie Powell2020-03-11 15:06:19 +0000
commit0a67b8861adfca7b09e59d9639e26b6bf71859a5 (patch)
treea478051a877b14b9a225e529949e90725f9412bd /src/modules/m_vhost.cpp
parentFix detection of the "plaintext" pseudo-hash being case sensitive. (diff)
Warn if the server config contains an unhashed password.
This will be made a hard failure in v4.
Diffstat (limited to 'src/modules/m_vhost.cpp')
-rw-r--r--src/modules/m_vhost.cpp10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/modules/m_vhost.cpp b/src/modules/m_vhost.cpp
index 573b9b31a..43d732ef9 100644
--- a/src/modules/m_vhost.cpp
+++ b/src/modules/m_vhost.cpp
@@ -103,13 +103,21 @@ class ModuleVHost : public Module
std::string mask = tag->getString("host");
if (mask.empty())
throw ModuleException("<vhost:host> is empty! at " + tag->getTagLocation());
+
std::string username = tag->getString("user");
if (username.empty())
throw ModuleException("<vhost:user> is empty! at " + tag->getTagLocation());
+
std::string pass = tag->getString("pass");
if (pass.empty())
throw ModuleException("<vhost:pass> is empty! at " + tag->getTagLocation());
- std::string hash = tag->getString("hash");
+
+ const std::string hash = tag->getString("hash", "plaintext", 1);
+ if (stdalgo::string::equalsci(hash, "plaintext"))
+ {
+ ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "<vhost> tag for %s at %s contains an plain text password, this is insecure!",
+ username.c_str(), tag->getTagLocation().c_str());
+ }
CustomVhost vhost(username, pass, hash, mask);
newhosts.insert(std::make_pair(username, vhost));