aboutsummaryrefslogtreecommitdiff
path: root/src/socketengine.cpp
diff options
context:
space:
mode:
authorGravatar Sadie Powell2022-12-13 13:34:44 +0000
committerGravatar Sadie Powell2022-12-13 14:17:50 +0000
commit33c08fc8aaf1ba5780a09d6ceaa2351abfd5e964 (patch)
treee5afb388297e20123ca77baaabc24d5ae6f3c49d /src/socketengine.cpp
parentShow the system error message when loading modules fails. (diff)
Deduplicate retrieving error messages on Windows.
Diffstat (limited to 'src/socketengine.cpp')
-rw-r--r--src/socketengine.cpp15
1 files changed, 4 insertions, 11 deletions
diff --git a/src/socketengine.cpp b/src/socketengine.cpp
index 85f2ddd04..06b948248 100644
--- a/src/socketengine.cpp
+++ b/src/socketengine.cpp
@@ -366,17 +366,10 @@ std::string SocketEngine::LastError()
#ifndef _WIN32
return strerror(errno);
#else
- char szErrorString[500];
- DWORD dwErrorCode = WSAGetLastError();
- if (FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, NULL, dwErrorCode, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)szErrorString, _countof(szErrorString), NULL) == 0)
- sprintf_s(szErrorString, _countof(szErrorString), "Error code: %u", dwErrorCode);
-
- std::string::size_type p;
- std::string ret = szErrorString;
- while ((p = ret.find_last_of("\r\n")) != std::string::npos)
- ret.erase(p, 1);
-
- return ret;
+ std::string err = GetErrorMessage(WSAGetLastError());
+ for (size_t pos = 0; ((pos = err.find_first_of("\r\n", pos)) != std::string::npos); )
+ err[pos] = ' ';
+ return err;
#endif
}