diff options
| author | 2022-10-22 20:45:22 +0100 | |
|---|---|---|
| committer | 2022-10-23 14:51:33 +0100 | |
| commit | 859088dac5b937208c7aff7fd3976bbc63329281 (patch) | |
| tree | 79b297813d7f2cb13e6967486340912ad72d0477 /src | |
| parent | Avoid spamming opers with notices when a SQL log provider is down. (diff) | |
More const correctness.
Diffstat (limited to 'src')
| -rw-r--r-- | src/channels.cpp | 2 | ||||
| -rw-r--r-- | src/configparser.cpp | 2 | ||||
| -rw-r--r-- | src/configreader.cpp | 8 | ||||
| -rw-r--r-- | src/inspsocket.cpp | 2 | ||||
| -rw-r--r-- | src/modulemanager.cpp | 2 | ||||
| -rw-r--r-- | src/modules.cpp | 8 | ||||
| -rw-r--r-- | src/modules/extra/m_ssl_gnutls.cpp | 2 | ||||
| -rw-r--r-- | src/modules/extra/m_ssl_mbedtls.cpp | 2 | ||||
| -rw-r--r-- | src/modules/extra/m_ssl_openssl.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_cloaking.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_log_sql.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_opermotd.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_permchannels.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_showfile.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_spanningtree/treesocket1.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_sqlauth.cpp | 2 | ||||
| -rw-r--r-- | src/modules/m_sqloper.cpp | 2 |
17 files changed, 23 insertions, 23 deletions
diff --git a/src/channels.cpp b/src/channels.cpp index 21e648c9f..ce20a689d 100644 --- a/src/channels.cpp +++ b/src/channels.cpp @@ -49,7 +49,7 @@ Channel::Channel(const std::string& cname, time_t ts) throw CoreException("Cannot create duplicate channel " + cname); } -void Channel::SetMode(ModeHandler* mh, bool on) +void Channel::SetMode(const ModeHandler* mh, bool on) { if (mh && mh->GetId() != ModeParser::MODEID_MAX) modes[mh->GetId()] = on; diff --git a/src/configparser.cpp b/src/configparser.cpp index 8afc20856..cbbfdc755 100644 --- a/src/configparser.cpp +++ b/src/configparser.cpp @@ -316,7 +316,7 @@ struct Parser final } } } - catch (CoreException& err) + catch (const CoreException& err) { stack.errstr << err.GetReason() << " at " << current.str(); if (tag) diff --git a/src/configreader.cpp b/src/configreader.cpp index ca4d77b6b..d91f5a389 100644 --- a/src/configreader.cpp +++ b/src/configreader.cpp @@ -360,7 +360,7 @@ void ServerConfig::Read() { valid = stack.ParseFile(ServerInstance->ConfigFileName, 0); } - catch (CoreException& err) + catch (const CoreException& err) { valid = false; errstr << err.GetReason() << std::endl; @@ -411,7 +411,7 @@ void ServerConfig::Apply(ServerConfig* old, const std::string& useruid) CrossCheckOperClassType(); CrossCheckConnectBlocks(old); } - catch (CoreException& ce) + catch (const CoreException& ce) { errstr << ce.GetReason() << std::endl; } @@ -664,7 +664,7 @@ void ConfigReaderThread::OnStop() ServerInstance->Logs.Debug("MODULE", "Rehashing " + modname); mod->ReadConfig(status); } - catch (CoreException& modex) + catch (const CoreException& modex) { ServerInstance->Logs.Normal("MODULE", "Exception caught: " + modex.GetReason()); if (user) @@ -680,7 +680,7 @@ void ConfigReaderThread::OnStop() ServerInstance->Logs.CloseLogs(); ServerInstance->Logs.OpenLogs(true); } - catch (CoreException& ex) + catch (const CoreException& ex) { ServerInstance->Logs.Normal("LOG", "Cannot open log files: " + ex.GetReason()); if (user) diff --git a/src/inspsocket.cpp b/src/inspsocket.cpp index b3b3bffdf..abbdbebb3 100644 --- a/src/inspsocket.cpp +++ b/src/inspsocket.cpp @@ -464,7 +464,7 @@ void StreamSocket::OnEventHandlerRead() { DoRead(); } - catch (CoreException& ex) + catch (const CoreException& ex) { ServerInstance->Logs.Normal("SOCKET", "Caught exception in socket processing on FD %d - '%s'", GetFd(), ex.GetReason().c_str()); diff --git a/src/modulemanager.cpp b/src/modulemanager.cpp index 2e210ba7f..0281541b0 100644 --- a/src/modulemanager.cpp +++ b/src/modulemanager.cpp @@ -102,7 +102,7 @@ bool ModuleManager::Load(const std::string& modname, bool defer) return false; } } - catch (CoreException& modexcept) + catch (const CoreException& modexcept) { this->NewServices = nullptr; diff --git a/src/modules.cpp b/src/modules.cpp index 308bbac0e..f30a980d8 100644 --- a/src/modules.cpp +++ b/src/modules.cpp @@ -213,13 +213,13 @@ bool ModuleManager::Detach(Implementation i, Module* mod) return stdalgo::erase(EventHandlers[i], mod); } -void ModuleManager::Attach(Implementation* i, Module* mod, size_t sz) +void ModuleManager::Attach(const Implementation* i, Module* mod, size_t sz) { for (size_t n = 0; n < sz; ++n) Attach(i[n], mod); } -void ModuleManager::Detach(Implementation* i, Module* mod, size_t sz) +void ModuleManager::Detach(const Implementation* i, Module* mod, size_t sz) { for (size_t n = 0; n < sz; ++n) Detach(i[n], mod); @@ -534,7 +534,7 @@ void ModuleManager::LoadAll() AddServices(servicemap[modname]); mod->init(); } - catch (CoreException& modexcept) + catch (const CoreException& modexcept) { LastModuleError = "Unable to initialize " + modname + ": " + modexcept.GetReason(); ServerInstance->Logs.Normal("MODULE", LastModuleError); @@ -556,7 +556,7 @@ void ModuleManager::LoadAll() ServerInstance->Logs.Debug("MODULE", "Reading configuration for %s", modname.c_str()); mod->ReadConfig(confstatus); } - catch (CoreException& modexcept) + catch (const CoreException& modexcept) { LastModuleError = "Unable to read the configuration for " + modname + ": " + modexcept.GetReason(); ServerInstance->Logs.Normal("MODULE", LastModuleError); diff --git a/src/modules/extra/m_ssl_gnutls.cpp b/src/modules/extra/m_ssl_gnutls.cpp index 1c148b36c..fcd58c6cc 100644 --- a/src/modules/extra/m_ssl_gnutls.cpp +++ b/src/modules/extra/m_ssl_gnutls.cpp @@ -1091,7 +1091,7 @@ class ModuleSSLGnuTLS final GnuTLS::Profile::Config profileconfig(name, tag); prov = std::make_shared<GnuTLSIOHookProvider>(this, profileconfig); } - catch (CoreException& ex) + catch (const CoreException& ex) { throw ModuleException(this, "Error while initializing TLS profile \"" + name + "\" at " + tag->source.str() + " - " + ex.GetReason()); } diff --git a/src/modules/extra/m_ssl_mbedtls.cpp b/src/modules/extra/m_ssl_mbedtls.cpp index be395b2be..ee9609cc7 100644 --- a/src/modules/extra/m_ssl_mbedtls.cpp +++ b/src/modules/extra/m_ssl_mbedtls.cpp @@ -919,7 +919,7 @@ private: mbedTLS::Profile::Config profileconfig(name, tag, ctr_drbg); prov = std::make_shared<mbedTLSIOHookProvider>(this, profileconfig); } - catch (CoreException& ex) + catch (const CoreException& ex) { throw ModuleException(this, "Error while initializing TLS profile \"" + name + "\" at " + tag->source.str() + " - " + ex.GetReason()); } diff --git a/src/modules/extra/m_ssl_openssl.cpp b/src/modules/extra/m_ssl_openssl.cpp index 7b73ee435..a38813f26 100644 --- a/src/modules/extra/m_ssl_openssl.cpp +++ b/src/modules/extra/m_ssl_openssl.cpp @@ -958,7 +958,7 @@ class ModuleSSLOpenSSL final { prov = std::make_shared<OpenSSLIOHookProvider>(this, name, tag); } - catch (CoreException& ex) + catch (const CoreException& ex) { throw ModuleException(this, "Error while initializing TLS profile \"" + name + "\" at " + tag->source.str() + " - " + ex.GetReason()); } diff --git a/src/modules/m_cloaking.cpp b/src/modules/m_cloaking.cpp index c8766478f..5d35173d1 100644 --- a/src/modules/m_cloaking.cpp +++ b/src/modules/m_cloaking.cpp @@ -165,7 +165,7 @@ public: creator->OnUserConnect(user); cloaks = ext.Get(user); } - catch (CoreException& modexcept) + catch (const CoreException& modexcept) { ServerInstance->Logs.Normal(MODNAME, "Exception caught when generating cloak: " + modexcept.GetReason()); return MODEACTION_DENY; diff --git a/src/modules/m_log_sql.cpp b/src/modules/m_log_sql.cpp index 4ace5ad3a..034062dc1 100644 --- a/src/modules/m_log_sql.cpp +++ b/src/modules/m_log_sql.cpp @@ -39,7 +39,7 @@ public: // Nothing to do here. } - void OnError(SQL::Error& error) override + void OnError(const SQL::Error& error) override { ServerInstance->SNO.WriteGlobalSno('a', "Unable to write to SQL log (query error: %s).", error.ToString()); } diff --git a/src/modules/m_opermotd.cpp b/src/modules/m_opermotd.cpp index b50b94b45..208496eae 100644 --- a/src/modules/m_opermotd.cpp +++ b/src/modules/m_opermotd.cpp @@ -111,7 +111,7 @@ public: cmd.opermotd = reader.GetVector(); InspIRCd::ProcessColors(cmd.opermotd); } - catch (CoreException&) + catch (const CoreException&) { // Nothing happens here as we do the error handling in ShowOperMOTD. } diff --git a/src/modules/m_permchannels.cpp b/src/modules/m_permchannels.cpp index 3cb35e514..e1daac763 100644 --- a/src/modules/m_permchannels.cpp +++ b/src/modules/m_permchannels.cpp @@ -311,7 +311,7 @@ public: { LoadDatabase(); } - catch (CoreException& e) + catch (const CoreException& e) { ServerInstance->Logs.Normal(MODNAME, "Error loading permchannels database: " + std::string(e.GetReason())); } diff --git a/src/modules/m_showfile.cpp b/src/modules/m_showfile.cpp index 456dfe50c..d50a327d5 100644 --- a/src/modules/m_showfile.cpp +++ b/src/modules/m_showfile.cpp @@ -158,7 +158,7 @@ public: { ReadTag(tag, newcmds); } - catch (CoreException& ex) + catch (const CoreException& ex) { ServerInstance->Logs.Normal(MODNAME, "Error: " + ex.GetReason() + " at " + tag->source.str()); } diff --git a/src/modules/m_spanningtree/treesocket1.cpp b/src/modules/m_spanningtree/treesocket1.cpp index af97b28ed..80f30411d 100644 --- a/src/modules/m_spanningtree/treesocket1.cpp +++ b/src/modules/m_spanningtree/treesocket1.cpp @@ -217,7 +217,7 @@ void TreeSocket::OnDataReady() { ProcessLine(line); } - catch (CoreException& ex) + catch (const CoreException& ex) { ServerInstance->Logs.Normal(MODNAME, "Error while processing: " + line); ServerInstance->Logs.Normal(MODNAME, ex.GetReason()); diff --git a/src/modules/m_sqlauth.cpp b/src/modules/m_sqlauth.cpp index ae7b31f1c..d3a4cbbe7 100644 --- a/src/modules/m_sqlauth.cpp +++ b/src/modules/m_sqlauth.cpp @@ -109,7 +109,7 @@ public: } } - void OnError(SQL::Error& error) override + void OnError(const SQL::Error& error) override { auto user = ServerInstance->Users.Find(uid); if (!user) diff --git a/src/modules/m_sqloper.cpp b/src/modules/m_sqloper.cpp index 453654c9e..6323d1ef2 100644 --- a/src/modules/m_sqloper.cpp +++ b/src/modules/m_sqloper.cpp @@ -112,7 +112,7 @@ public: } } - void OnError(SQL::Error& error) override + void OnError(const SQL::Error& error) override { ServerInstance->Logs.Normal(MODNAME, "query failed (%s)", error.ToString()); ServerInstance->SNO.WriteGlobalSno('a', "m_sqloper: Failed to update blocks from database"); |
