diff options
Diffstat (limited to 'src/modules/m_spanningtree')
23 files changed, 48 insertions, 48 deletions
diff --git a/src/modules/m_spanningtree/fjoin.cpp b/src/modules/m_spanningtree/fjoin.cpp index 0b208509f..c2152cf54 100644 --- a/src/modules/m_spanningtree/fjoin.cpp +++ b/src/modules/m_spanningtree/fjoin.cpp @@ -117,7 +117,7 @@ CmdResult CommandFJoin::Handle(User* srcuser, Params& params) time_t TS = ServerCommand::ExtractTS(params[1]); const std::string& channel = params[0]; - auto chan = ServerInstance->Channels.Find(channel); + auto* chan = ServerInstance->Channels.Find(channel); bool apply_other_sides_modes = true; TreeServer* const sourceserver = TreeServer::Get(srcuser); @@ -201,7 +201,7 @@ void CommandFJoin::ProcessModeUUIDPair(const std::string& item, TreeServer* sour // Comma not required anymore if the user has no modes const std::string::size_type ubegin = (comma == std::string::npos ? 0 : comma+1); std::string uuid(item, ubegin, UIDGenerator::UUID_LENGTH); - auto who = ServerInstance->Users.FindUUID(uuid); + auto* who = ServerInstance->Users.FindUUID(uuid); if (!who) { // Probably KILLed, ignore diff --git a/src/modules/m_spanningtree/ftopic.cpp b/src/modules/m_spanningtree/ftopic.cpp index ddbfe9f3e..19c2e36ea 100644 --- a/src/modules/m_spanningtree/ftopic.cpp +++ b/src/modules/m_spanningtree/ftopic.cpp @@ -28,7 +28,7 @@ /** FTOPIC command */ CmdResult CommandFTopic::Handle(User* user, Params& params) { - auto c = ServerInstance->Channels.Find(params[0]); + auto* c = ServerInstance->Channels.Find(params[0]); if (!c) return CmdResult::FAILURE; diff --git a/src/modules/m_spanningtree/idle.cpp b/src/modules/m_spanningtree/idle.cpp index fa7e87548..b6888f16d 100644 --- a/src/modules/m_spanningtree/idle.cpp +++ b/src/modules/m_spanningtree/idle.cpp @@ -39,7 +39,7 @@ CmdResult CommandIdle::HandleRemote(RemoteUser* issuer, Params& params) * the number of seconds 'issuer' has been idle. */ - auto target = ServerInstance->Users.FindUUID(params[0], true); + auto* target = ServerInstance->Users.FindUUID(params[0], true); if (!target) return CmdResult::FAILURE; diff --git a/src/modules/m_spanningtree/ijoin.cpp b/src/modules/m_spanningtree/ijoin.cpp index c781ba17d..ca082061d 100644 --- a/src/modules/m_spanningtree/ijoin.cpp +++ b/src/modules/m_spanningtree/ijoin.cpp @@ -27,7 +27,7 @@ CmdResult CommandIJoin::HandleRemote(RemoteUser* user, Params& params) { - auto chan = ServerInstance->Channels.Find(params[0]); + auto* chan = ServerInstance->Channels.Find(params[0]); if (!chan) { // Desync detected, recover @@ -60,7 +60,7 @@ CmdResult CommandIJoin::HandleRemote(RemoteUser* user, Params& params) CmdResult CommandResync::HandleServer(TreeServer* server, CommandBase::Params& params) { ServerInstance->Logs.Debug(MODNAME, "Resyncing " + params[0]); - auto chan = ServerInstance->Channels.Find(params[0]); + auto* chan = ServerInstance->Channels.Find(params[0]); if (!chan) { // This can happen for a number of reasons, safe to ignore diff --git a/src/modules/m_spanningtree/main.cpp b/src/modules/m_spanningtree/main.cpp index d7406aeb0..5617a7aea 100644 --- a/src/modules/m_spanningtree/main.cpp +++ b/src/modules/m_spanningtree/main.cpp @@ -143,7 +143,7 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops) Parent = Current->GetParent()->GetName(); } - for (const auto& server : Current->GetChildren()) + for (auto* server : Current->GetChildren()) { if ((server->Hidden) || ((Utils->HideServices) && (server->IsService()))) { @@ -242,7 +242,7 @@ void ModuleSpanningTree::ConnectServer(const std::shared_ptr<Link>& x, const std if (sa.family() != AF_UNSPEC) { // Create a TreeServer object that will start connecting immediately in the background - auto newsocket = new TreeSocket(x, y, sa); + auto* newsocket = new TreeSocket(x, y, sa); if (!newsocket->HasFd()) { ServerInstance->SNO.WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.", @@ -265,7 +265,7 @@ void ModuleSpanningTree::ConnectServer(const std::shared_ptr<Link>& x, const std start_type = DNS::QUERY_A; } - auto snr = new ServerNameResolver(*DNS, x->IPAddr, x, start_type, y); + auto* snr = new ServerNameResolver(*DNS, x->IPAddr, x, start_type, y); try { DNS->Process(snr); @@ -714,7 +714,7 @@ namespace compatbuffer << '=' << compatlinkstring; } - for (const auto& child : Utils->TreeRoot->GetChildren()) + for (const auto* child : Utils->TreeRoot->GetChildren()) { if (!child->GetSocket()) continue; // Should never happen? @@ -753,7 +753,7 @@ void ModuleSpanningTree::OnUnloadModule(Module* mod) restart: // Close all connections which use an IO hook provided by this module - for (const auto& child : Utils->TreeRoot->GetChildren()) + for (const auto* child : Utils->TreeRoot->GetChildren()) { TreeSocket* sock = child->GetSocket(); if (sock->GetModHook(mod)) @@ -870,7 +870,7 @@ ModuleSpanningTree::~ModuleSpanningTree() { ServerInstance->PI = &ServerInstance->DefaultProtocolInterface; - auto newsrv = new Server(ServerInstance->Config->GetSID(), ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc); + auto* newsrv = new Server(ServerInstance->Config->GetSID(), ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc); SetLocalUsersServer(newsrv); delete Utils; diff --git a/src/modules/m_spanningtree/metadata.cpp b/src/modules/m_spanningtree/metadata.cpp index e1514a54b..df51148cd 100644 --- a/src/modules/m_spanningtree/metadata.cpp +++ b/src/modules/m_spanningtree/metadata.cpp @@ -49,11 +49,11 @@ CmdResult CommandMetadata::Handle(User* srcuser, Params& params) if (params.size() < 6) throw ProtocolException("Insufficient parameters for channel METADATA"); - auto u = ServerInstance->Users.FindUUID(params[1]); + auto* u = ServerInstance->Users.FindUUID(params[1]); if (!u) return CmdResult::FAILURE; // User does not exist. - auto c = ServerInstance->Channels.Find(params[2]); + auto* c = ServerInstance->Channels.Find(params[2]); if (!c) return CmdResult::FAILURE; // Channel does not exist. @@ -79,7 +79,7 @@ CmdResult CommandMetadata::Handle(User* srcuser, Params& params) if (params.size() < 3) throw ProtocolException("Insufficient parameters for channel METADATA"); - auto c = ServerInstance->Channels.Find(params[0]); + auto* c = ServerInstance->Channels.Find(params[0]); if (!c) return CmdResult::FAILURE; @@ -97,7 +97,7 @@ CmdResult CommandMetadata::Handle(User* srcuser, Params& params) } else { - auto u = ServerInstance->Users.FindUUID(params[0]); + auto* u = ServerInstance->Users.FindUUID(params[0]); if (u) { ExtensionItem* item = ServerInstance->Extensions.GetItem(params[1]); diff --git a/src/modules/m_spanningtree/netburst.cpp b/src/modules/m_spanningtree/netburst.cpp index b5c30f782..00bad9b97 100644 --- a/src/modules/m_spanningtree/netburst.cpp +++ b/src/modules/m_spanningtree/netburst.cpp @@ -150,7 +150,7 @@ void TreeSocket::SendServers(TreeServer* Current, TreeServer* s) { SendServerInfo(Current); - for (const auto& recursive_server : Current->GetChildren()) + for (auto* recursive_server : Current->GetChildren()) { if (recursive_server != s) { @@ -202,7 +202,7 @@ void TreeSocket::SendListModes(Channel* chan) return; } - for (const auto& mode : ServerInstance->Modes.GetListModes()) + for (auto* mode : ServerInstance->Modes.GetListModes()) { ListModeBase::ModeList* list = mode->GetList(chan); if (!list || list->empty()) @@ -221,7 +221,7 @@ void TreeSocket::SendListModes(Channel* chan) void TreeSocket::SendLegacyListModes(Channel* chan) { FModeBuilder fmode(chan); - for (const auto& mode : ServerInstance->Modes.GetListModes()) + for (auto* mode : ServerInstance->Modes.GetListModes()) { ListModeBase::ModeList* list = mode->GetList(chan); if (!list) diff --git a/src/modules/m_spanningtree/nick.cpp b/src/modules/m_spanningtree/nick.cpp index 4663a5df2..ae021d0ab 100644 --- a/src/modules/m_spanningtree/nick.cpp +++ b/src/modules/m_spanningtree/nick.cpp @@ -37,7 +37,7 @@ CmdResult CommandNick::HandleRemote(::RemoteUser* user, Params& params) * On nick messages, check that the nick doesn't already exist here. * If it does, perform collision logic. */ - auto x = ServerInstance->Users.FindNick(params[0], true); + auto* x = ServerInstance->Users.FindNick(params[0], true); if (x && x != user) { // 'x' is the already existing user using the same nick as params[0] diff --git a/src/modules/m_spanningtree/opertype.cpp b/src/modules/m_spanningtree/opertype.cpp index 0911891dd..f5cacc0df 100644 --- a/src/modules/m_spanningtree/opertype.cpp +++ b/src/modules/m_spanningtree/opertype.cpp @@ -36,7 +36,7 @@ private: auto it = tags.find(tag); if (it != tags.end()) { - for (const char& chr : ClientProtocol::Message::UnescapeTag(it->second.value)) + for (const auto chr : ClientProtocol::Message::UnescapeTag(it->second.value)) { size_t idx = ModeParser::GetModeIndex(chr); if (idx != ModeParser::MODEID_MAX) diff --git a/src/modules/m_spanningtree/override_map.cpp b/src/modules/m_spanningtree/override_map.cpp index f98d79c8e..7bbe72b13 100644 --- a/src/modules/m_spanningtree/override_map.cpp +++ b/src/modules/m_spanningtree/override_map.cpp @@ -64,7 +64,7 @@ static void GetDepthAndLen(TreeServer* current, unsigned int depth, unsigned int if (current->rawversion.length() > max_version) max_version = current->rawversion.length(); - for (const auto& child : current->GetChildren()) + for (auto* child : current->GetChildren()) GetDepthAndLen(child, depth + 1, max_depth, max_len, max_version); } diff --git a/src/modules/m_spanningtree/override_whois.cpp b/src/modules/m_spanningtree/override_whois.cpp index 70c711f02..b0d1abe6a 100644 --- a/src/modules/m_spanningtree/override_whois.cpp +++ b/src/modules/m_spanningtree/override_whois.cpp @@ -30,7 +30,7 @@ ModResult ModuleSpanningTree::HandleRemoteWhois(const CommandBase::Params& parameters, User* user) { - auto remote = ServerInstance->Users.FindNick(parameters[1]); + auto* remote = ServerInstance->Users.FindNick(parameters[1]); if (remote && !IS_LOCAL(remote)) { CmdBuilder(user, "IDLE").push(remote->uuid).Unicast(remote); diff --git a/src/modules/m_spanningtree/postcommand.cpp b/src/modules/m_spanningtree/postcommand.cpp index e9d568010..bb0c0d922 100644 --- a/src/modules/m_spanningtree/postcommand.cpp +++ b/src/modules/m_spanningtree/postcommand.cpp @@ -97,7 +97,7 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, CommandBase* thiscm } if (ServerInstance->Channels.IsPrefix(dest[0])) { - auto c = ServerInstance->Channels.Find(dest); + auto* c = ServerInstance->Channels.Find(dest); if (!c) return; // TODO OnBuildExemptList hook was here @@ -114,7 +114,7 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, CommandBase* thiscm else { // user target? - auto d = ServerInstance->Users.Find(dest); + auto* d = ServerInstance->Users.Find(dest); if (!d || IS_LOCAL(d)) return; TreeServer* tsd = TreeServer::Get(d)->GetRoute(); diff --git a/src/modules/m_spanningtree/resolvers.cpp b/src/modules/m_spanningtree/resolvers.cpp index 4d83c642c..e6dd2a54a 100644 --- a/src/modules/m_spanningtree/resolvers.cpp +++ b/src/modules/m_spanningtree/resolvers.cpp @@ -65,7 +65,7 @@ void ServerNameResolver::OnLookupComplete(const DNS::Query* r) TreeServer* CheckDupe = Utils->FindServer(link->Name); if (!CheckDupe) /* Check that nobody tried to connect it successfully while we were resolving */ { - auto newsocket = new TreeSocket(link, autoconnect, sa); + auto* newsocket = new TreeSocket(link, autoconnect, sa); if (!newsocket->HasFd()) { /* Something barfed, show the opers */ @@ -86,7 +86,7 @@ void ServerNameResolver::OnError(const DNS::Query* r) if (question.type == DNS::QUERY_AAAA) { - auto snr = new ServerNameResolver(this->manager, question.name, link, DNS::QUERY_A, autoconnect); + auto* snr = new ServerNameResolver(this->manager, question.name, link, DNS::QUERY_A, autoconnect); try { this->manager->Process(snr); @@ -115,7 +115,7 @@ bool SecurityIPResolver::CheckIPv4() if (question.type != DNS::QUERY_AAAA) return false; - auto res = new SecurityIPResolver(creator, manager, question.name, link, DNS::QUERY_A); + auto* res = new SecurityIPResolver(creator, manager, question.name, link, DNS::QUERY_A); try { this->manager->Process(res); diff --git a/src/modules/m_spanningtree/save.cpp b/src/modules/m_spanningtree/save.cpp index 71c4f8f80..0d8640dbf 100644 --- a/src/modules/m_spanningtree/save.cpp +++ b/src/modules/m_spanningtree/save.cpp @@ -31,7 +31,7 @@ */ CmdResult CommandSave::Handle(User* user, Params& params) { - auto u = ServerInstance->Users.FindUUID(params[0]); + auto* u = ServerInstance->Users.FindUUID(params[0]); if (!u) return CmdResult::FAILURE; diff --git a/src/modules/m_spanningtree/server.cpp b/src/modules/m_spanningtree/server.cpp index 9a8a76449..7804ee096 100644 --- a/src/modules/m_spanningtree/server.cpp +++ b/src/modules/m_spanningtree/server.cpp @@ -66,7 +66,7 @@ CmdResult CommandServer::HandleServer(TreeServer* ParentOfThis, Params& params) TreeServer* route = ParentOfThis->GetRoute(); std::shared_ptr<Link> lnk = Utils->FindLink(route->GetName()); - auto Node = new TreeServer(servername, description, sid, ParentOfThis, ParentOfThis->GetSocket(), lnk ? lnk->Hidden : false); + auto* Node = new TreeServer(servername, description, sid, ParentOfThis, ParentOfThis->GetSocket(), lnk ? lnk->Hidden : false); HandleExtra(Node, params); diff --git a/src/modules/m_spanningtree/svsjoin.cpp b/src/modules/m_spanningtree/svsjoin.cpp index d774ec5b2..db55b4cb9 100644 --- a/src/modules/m_spanningtree/svsjoin.cpp +++ b/src/modules/m_spanningtree/svsjoin.cpp @@ -32,7 +32,7 @@ CmdResult CommandSVSJoin::Handle(User* user, Params& parameters) return CmdResult::FAILURE; // Check target exists - auto u = ServerInstance->Users.FindUUID(parameters[0]); + auto* u = ServerInstance->Users.FindUUID(parameters[0]); if (!u) return CmdResult::FAILURE; diff --git a/src/modules/m_spanningtree/svsnick.cpp b/src/modules/m_spanningtree/svsnick.cpp index 0ad393796..6423a8437 100644 --- a/src/modules/m_spanningtree/svsnick.cpp +++ b/src/modules/m_spanningtree/svsnick.cpp @@ -29,7 +29,7 @@ CmdResult CommandSVSNick::Handle(User* user, Params& parameters) { - auto u = ServerInstance->Users.Find(parameters[0]); + auto* u = ServerInstance->Users.Find(parameters[0]); if (u && IS_LOCAL(u)) { diff --git a/src/modules/m_spanningtree/svspart.cpp b/src/modules/m_spanningtree/svspart.cpp index 18ebfc797..cff40141a 100644 --- a/src/modules/m_spanningtree/svspart.cpp +++ b/src/modules/m_spanningtree/svspart.cpp @@ -28,11 +28,11 @@ CmdResult CommandSVSPart::Handle(User* user, Params& parameters) { - auto u = ServerInstance->Users.FindUUID(parameters[0]); + auto* u = ServerInstance->Users.FindUUID(parameters[0]); if (!u) return CmdResult::FAILURE; - auto c = ServerInstance->Channels.Find(parameters[1]); + auto* c = ServerInstance->Channels.Find(parameters[1]); if (!c) return CmdResult::FAILURE; diff --git a/src/modules/m_spanningtree/translate.cpp b/src/modules/m_spanningtree/translate.cpp index 203b3c264..bbf33d82e 100644 --- a/src/modules/m_spanningtree/translate.cpp +++ b/src/modules/m_spanningtree/translate.cpp @@ -33,7 +33,7 @@ std::string Translate::ModeChangeListToParams(const Modes::ChangeList::List& mod if (mh->IsPrefixMode()) { - auto target = ServerInstance->Users.Find(item.param); + auto* target = ServerInstance->Users.Find(item.param); if (target) { ret.append(target->uuid); diff --git a/src/modules/m_spanningtree/treeserver.cpp b/src/modules/m_spanningtree/treeserver.cpp index efd422986..ed84ca70f 100644 --- a/src/modules/m_spanningtree/treeserver.cpp +++ b/src/modules/m_spanningtree/treeserver.cpp @@ -144,7 +144,7 @@ void TreeServer::FinishBurstInternal() behind_bursting--; ServerInstance->Logs.Debug(MODNAME, "FinishBurstInternal() %s behind_bursting %u", GetName().c_str(), behind_bursting); - for (const auto& child : Children) + for (auto* child : Children) child->FinishBurstInternal(); } @@ -201,7 +201,7 @@ void TreeServer::SQuitInternal(unsigned int& num_lost_servers, bool error) ServerInstance->Logs.Debug(MODNAME, "Server %s lost in split", GetName().c_str()); - for (const auto& server : Children) + for (auto* server : Children) server->SQuitInternal(num_lost_servers, error); // Mark server as dead @@ -266,7 +266,7 @@ void TreeServer::AddHashEntry() Cullable::Result TreeServer::Cull() { // Recursively cull all servers that are under us in the tree - for (const auto& server : Children) + for (auto* server : Children) server->Cull(); if (!IsRoot()) @@ -277,7 +277,7 @@ Cullable::Result TreeServer::Cull() TreeServer::~TreeServer() { // Recursively delete all servers that are under us in the tree first - for (const auto& child : Children) + for (const auto* child : Children) delete child; // Delete server user unless it's us diff --git a/src/modules/m_spanningtree/treesocket2.cpp b/src/modules/m_spanningtree/treesocket2.cpp index 5ab5778b1..8d1f39e02 100644 --- a/src/modules/m_spanningtree/treesocket2.cpp +++ b/src/modules/m_spanningtree/treesocket2.cpp @@ -242,7 +242,7 @@ User* TreeSocket::FindSource(const std::string& prefix, const std::string& comma else { // If the prefix string is a uuid FindUUID() returns the appropriate User object - auto user = ServerInstance->Users.FindUUID(prefix); + auto* user = ServerInstance->Users.FindUUID(prefix); if (user) return user; } @@ -291,7 +291,7 @@ void TreeSocket::ProcessTag(User* source, const std::string& tag, ClientProtocol tagkey.assign(tag); } - for (const auto& subscriber : Utils->Creator->tagevprov.GetSubscribers()) + for (auto* subscriber : Utils->Creator->tagevprov.GetSubscribers()) { ClientProtocol::MessageTagProvider* const tagprov = static_cast<ClientProtocol::MessageTagProvider*>(subscriber); const ModResult res = tagprov->OnProcessTag(source, tagkey, tagval); diff --git a/src/modules/m_spanningtree/uid.cpp b/src/modules/m_spanningtree/uid.cpp index 62e1c421f..24477acc8 100644 --- a/src/modules/m_spanningtree/uid.cpp +++ b/src/modules/m_spanningtree/uid.cpp @@ -48,7 +48,7 @@ CmdResult CommandUID::HandleServer(TreeServer* remoteserver, CommandBase::Params throw ProtocolException("Invalid mode string"); // See if there is a nick collision - auto collideswith = ServerInstance->Users.FindNick(params[2]); + auto* collideswith = ServerInstance->Users.FindNick(params[2]); if (collideswith && !collideswith->IsFullyConnected()) { // User that the incoming user is colliding with is not fully connected, we force nick change the @@ -77,7 +77,7 @@ CmdResult CommandUID::HandleServer(TreeServer* remoteserver, CommandBase::Params /* For remote users, we pass the UUID they sent to the constructor. * If the UUID already exists User::User() throws an exception which causes this connection to be closed. */ - auto _new = new SpanningTree::RemoteUser(params[0], remoteserver); + auto* _new = new SpanningTree::RemoteUser(params[0], remoteserver); ServerInstance->Users.clientlist[params[2]] = _new; _new->nick = params[2]; _new->ChangeRealHost(params[3], false); diff --git a/src/modules/m_spanningtree/utils.cpp b/src/modules/m_spanningtree/utils.cpp index 06804c0ec..6fd1d165e 100644 --- a/src/modules/m_spanningtree/utils.cpp +++ b/src/modules/m_spanningtree/utils.cpp @@ -167,7 +167,7 @@ void SpanningTreeUtilities::GetListOfServersForChannel(const Channel* c, TreeSoc // Check whether the servers which do not have users in the channel might need this message. This // is used to keep the chanhistory module synchronised between servers. - for (const auto& child : children) + for (const auto* child : children) { ModResult result = Creator->broadcasteventprov.FirstResult(&ServerProtocol::BroadcastEventListener::OnBroadcastMessage, c, child); if (result == MOD_RES_ALLOW) @@ -179,7 +179,7 @@ void SpanningTreeUtilities::DoOneToAllButSender(const CmdBuilder& params, const { const std::string& FullLine = params.str(); - for (const auto& Route : TreeRoot->GetChildren()) + for (const auto* Route : TreeRoot->GetChildren()) { // Send the line if the route isn't the path to the one to be omitted if (Route != omitroute) @@ -218,7 +218,7 @@ void SpanningTreeUtilities::RefreshIPCache() ValidIPs.push_back(L->IPAddr); else if (this->Creator->DNS) { - auto sr = new SecurityIPResolver(Creator, *this->Creator->DNS, L->IPAddr, L, DNS::QUERY_AAAA); + auto* sr = new SecurityIPResolver(Creator, *this->Creator->DNS, L->IPAddr, L, DNS::QUERY_AAAA); try { this->Creator->DNS->Process(sr); @@ -367,7 +367,7 @@ void SpanningTreeUtilities::SendChannelMessage(const User* source, const Channel TreeSocketSet list; this->GetListOfServersForChannel(target, list, status, exempt_list); - for (const auto& Sock : list) + for (auto* Sock : list) { if (Sock != omit) Sock->WriteLine(msg); @@ -397,7 +397,7 @@ std::string SpanningTreeUtilities::BuildLinkString(uint16_t proto, Module* mod) void SpanningTreeUtilities::SendListLimits(Channel* chan, TreeSocket* sock) { std::stringstream buffer; - for (const auto& lm : ServerInstance->Modes.GetListModes()) + for (auto* lm : ServerInstance->Modes.GetListModes()) buffer << lm->GetModeChar() << " " << lm->GetLimit(chan) << " "; std::string bufferstr = buffer.str(); |