summaryrefslogtreecommitdiff
path: root/src/inspsocket.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Rewrite BufferedSocket::BindAddr to actually make sense, and not infinite ↵Gravatar w00t2009-03-091-61/+86
| | | | | | | | | | loop under some conditions, etc. This also splits a lot of it into DoBindMagic(), for readability. Seems to work okay on an invalid bind and nonexistant bind.. Fixes bug #754, reported by HiroP and Indoril. Fix FD leak in some circumstances: if bind fails hard (requested address couldn't be bound), Close() the socket. Also fixes a deficiency of the previous commit in that if one address failed to bind, the FD would be invalidated. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11189 e03df62e-2008-0410-955e-edbf42e46eb7
* Fix minor memory leak, patch by Darom. Closes bug #699. Thanks!`Gravatar w00t2009-02-031-0/+2
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11025 e03df62e-2008-0410-955e-edbf42e46eb7
* Update copyrights for 2009.Gravatar w00t2009-01-021-1/+1
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10932 e03df62e-2008-0410-955e-edbf42e46eb7
* Be consistent. Use ServerInstance in all places instead of 'Instance' in ↵Gravatar w00t2008-09-211-42/+42
| | | | | | half. This has bugged me forever :p. I think I got all of extra/ too.. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10579 e03df62e-2008-0410-955e-edbf42e46eb7
* Cleanup of some internals. Tested via m_httpd.Gravatar w00t2008-09-121-52/+30
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10527 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove some duplication, everything calls the SE equivilant anyway.Gravatar w00t2008-09-111-5/+0
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10525 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove useless parameter.Gravatar w00t2008-09-111-3/+3
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10524 e03df62e-2008-0410-955e-edbf42e46eb7
* Minor stylistic improvements.Gravatar w00t2008-09-111-7/+8
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10515 e03df62e-2008-0410-955e-edbf42e46eb7
* Fix a compile oops.Gravatar w00t2008-09-111-1/+1
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10513 e03df62e-2008-0410-955e-edbf42e46eb7
* There is absolutely no need to cache connect timeout.Gravatar w00t2008-09-111-5/+4
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10512 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove an unused member.Gravatar w00t2008-09-111-1/+0
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10511 e03df62e-2008-0410-955e-edbf42e46eb7
* Windows doesn't need blocking connect, IOCP was the cause of that.Gravatar w00t2008-09-111-9/+1
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10510 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove WaitingForWriteEvent, it seems to do *nothing* except confuse things. ↵Gravatar w00t2008-09-111-17/+7
| | | | | | Also, don't close socket on http if FlushWriteBuf doesn't write it all in one go, in fact, don't try FlushWriteBuf at all - use the sockets default of waiting to be told it's safe to write data. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10509 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove a totally redundant method (this is already available via inheritance ↵Gravatar w00t2008-09-091-5/+0
| | | | | | from EventHandler) git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10490 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove listening from BufferedSocket, it's bloaty and horrid. We have a ↵Gravatar w00t2008-09-081-124/+32
| | | | | | ListenSocketBase class to handle this instead now. :) git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10470 e03df62e-2008-0410-955e-edbf42e46eb7
* Move socket hooking in inspsocket to utilise the new system properly.Gravatar w00t2008-09-071-13/+10
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10449 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove last vestige of libircdfoo, by changing tag into a single ↵Gravatar w00t2008-07-291-1/+1
| | | | | | identifier marking object as requiring compilation into a .o (minor commit) git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10076 e03df62e-2008-0410-955e-edbf42e46eb7
* Fix the 4-byte read madness discovered by psychonGravatar brain2008-07-191-3/+3
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10045 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove individual read buffers inside of BufferedSocket, use the shared ↵Gravatar w00t2008-07-121-4/+5
| | | | | | netbuffer instead, like users. This means a 65kb saving per BufferedSocket. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9960 e03df62e-2008-0410-955e-edbf42e46eb7
* Fix an off-by-one which could possibly perhaps cause djGrrr/satmd's bug by ↵Gravatar w00t2008-07-021-3/+9
| | | | | | dropping a read buffer into the bit bucket if it was of an exact enough size to cause problems. No guarentees. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9944 e03df62e-2008-0410-955e-edbf42e46eb7
* Listening bufferedsockets dont have an OnRawSocketClose event as theyre ↵Gravatar brain2008-05-191-1/+2
| | | | | | never 'opened' git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9773 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove call to FlushWriteBuffer from BufferedSocket::Write(), this means we ↵Gravatar w00t2008-04-011-8/+16
| | | | | | don't try write() pointlessly when we may very well not (chewing CPU), and instead waits for the socketengine to tell us we can write. Tested, works fine. (nothing used this return value anyway) git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9247 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove deprecated BufferedSocket::MarkAsClosed()Gravatar w00t2008-04-011-4/+0
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9246 e03df62e-2008-0410-955e-edbf42e46eb7
* Convert remaining InspIRCd::Log() calls to new logging systemGravatar aquanight2008-02-221-10/+10
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9001 e03df62e-2008-0410-955e-edbf42e46eb7
* Commit patch from danieldg that makes a ton of stuff const-safe for latest ↵Gravatar brain2008-02-131-1/+1
| | | | | | warn-happy trigger-happy gcc4 (thanks) git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8922 e03df62e-2008-0410-955e-edbf42e46eb7
* Add -Wshadow to cflags, and fix a bunch of warnings that come with it. Add a ↵Gravatar w00t2008-02-111-4/+4
| | | | | | note to webirc that needs looking at. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8892 e03df62e-2008-0410-955e-edbf42e46eb7
* IPv6 fix, thanks to danieldg. Doesn't affect 1.1.Gravatar w00t2008-01-141-1/+6
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8709 e03df62e-2008-0410-955e-edbf42e46eb7
* Header update: 2007 -> 2008Gravatar w00t2008-01-101-1/+1
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8694 e03df62e-2008-0410-955e-edbf42e46eb7
* Argh, i give upGravatar brain2007-11-121-0/+2
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8594 e03df62e-2008-0410-955e-edbf42e46eb7
* NOTE: our stuff for parsing multiple dns replies for dnsbl with an 'A record ↵Gravatar brain2007-11-121-0/+1
| | | | | | | | | reply' is broken. We will fix this at some later date. It was breaking other stuff git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8591 e03df62e-2008-0410-955e-edbf42e46eb7
* This works with multiple remote includes now except it hangs when an include ↵Gravatar brain2007-11-111-0/+2
| | | | | | is within an include git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8590 e03df62e-2008-0410-955e-edbf42e46eb7
* Comment a message out that people regularly attempt to interpretGravatar w00t2007-11-011-1/+4
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8453 e03df62e-2008-0410-955e-edbf42e46eb7
* Pedantic safeGravatar brain2007-10-231-3/+3
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8317 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove the need for a bunch of the hard coded arrays/hashes by scanning the ↵Gravatar brain2007-10-221-0/+2
| | | | | | src/ dir for tag comments, like in modules git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8307 e03df62e-2008-0410-955e-edbf42e46eb7
* InspSocket -> BufferedSocket. Paves the way for a SimpleSocket class which ↵Gravatar w00t2007-10-151-30/+30
| | | | | | ident etc will use. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8206 e03df62e-2008-0410-955e-edbf42e46eb7
* Fix potential for ssl to block, based on patch submitted by djGrrr, adjusted ↵Gravatar brain2007-10-131-0/+2
| | | | | | for trunk new socket engine, thanks git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8154 e03df62e-2008-0410-955e-edbf42e46eb7
* Fixed a rare infinite loop in InspSocket::FlushWriteBuffer() - this could ↵Gravatar special2007-09-131-0/+6
| | | | | | only affect a few rarely used modules, and is difficult to trigger. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8031 e03df62e-2008-0410-955e-edbf42e46eb7
* Remove more unnecessary header trafficGravatar w00t2007-08-271-1/+0
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7887 e03df62e-2008-0410-955e-edbf42e46eb7
* Someone really should fix the blocking connects on windows craq...Gravatar brain2007-08-231-0/+2
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7813 e03df62e-2008-0410-955e-edbf42e46eb7
* Craquity craq De-craq!Gravatar brain2007-08-231-21/+14
| | | | | | | | | | This is probably broken on windows, do not attempt to use there yet unless you like broken stuff. Cant say for sure as i havent even tried to build yet and most likely wont tonight. --- Abstract most of the berkely socket API out into SocketEngine derived classes. SocketEngine base class implements standard berkely sockets that 'real mens systems' like linux and freebsd have. For socketengine_iocp we implement the windows specific nonesense like the special things needed for udp and accept (ick). All this to eliminate a bunch of ifdefs. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7810 e03df62e-2008-0410-955e-edbf42e46eb7
* Add comments explaining why we have sockaddr[2] so that nobody goes ↵Gravatar brain2007-08-201-0/+3
| | | | | | 'w...t..f...' git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7779 e03df62e-2008-0410-955e-edbf42e46eb7
* Fix a bug i just introduced while playing with the codeGravatar brain2007-08-201-1/+1
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7777 e03df62e-2008-0410-955e-edbf42e46eb7
* The only possibility for the issue sts found is that a socket is deleted but ↵Gravatar brain2007-08-201-2/+2
| | | | | | | | | | | also ends up in the socket cull list somehow. To ensure that the socket does not get deleted, remove the delete and replace with an explicit call to insert into the socket cull list. We were grappling with these issues in early 1.1 with the userrec cull list, too. NOTE for later 1.2's consider making CullList a base class which we can derive from to delete lists of other items than userrecs. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7775 e03df62e-2008-0410-955e-edbf42e46eb7
* Windows specific data types in EventHandler are now Extensible itemsGravatar brain2007-07-271-0/+2
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7599 e03df62e-2008-0410-955e-edbf42e46eb7
* Tidyups, remove of ifdefsGravatar brain2007-07-271-13/+8
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7597 e03df62e-2008-0410-955e-edbf42e46eb7
* Found the bug, turns out i just introduced it with the last commit :pGravatar brain2007-07-271-7/+1
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7591 e03df62e-2008-0410-955e-edbf42e46eb7
* Some smart tricks to eliminate win32 ifdefs that are creeping into portable ↵Gravatar brain2007-07-271-0/+2
| | | | | | files git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7589 e03df62e-2008-0410-955e-edbf42e46eb7
* * Sockets will now always be nonblocking on win32 version of InspIRCd. There ↵Gravatar burlex2007-07-231-2/+7
| | | | | | | | were some cases (mainly in TreeSockets) where a socket would not get restored to nonblocking mode after a connect() call, resulting in the server getting stuck on a blocking send() call causing freezeups. * configure will now compile under VC7 again. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7500 e03df62e-2008-0410-955e-edbf42e46eb7
* Ive tidied up the mode count stuff, but i still cant duplicate negative ↵Gravatar brain2007-07-181-2/+2
| | | | | | invisible counts. :( git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7474 e03df62e-2008-0410-955e-edbf42e46eb7
* OOPS! We try again, since I'm smoking craq. LF is 0x0a NOT CR.Gravatar peavey2007-07-161-1/+750
| | | | git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@7456 e03df62e-2008-0410-955e-edbf42e46eb7