From 2b33c3c303a252744275f3d4fee84e7e76f16976 Mon Sep 17 00:00:00 2001
From: Sadie Powell
Date: Tue, 20 Dec 2022 10:51:37 +0000
Subject: Don't automatically fall back to ToNetwork from ToInternal.

Only one thing used this and its really unclear especially when
SimpleExtItem does the opposite.
---
 src/extensible.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'src/extensible.cpp')

diff --git a/src/extensible.cpp b/src/extensible.cpp
index 7230fb174..cc9dd11bf 100644
--- a/src/extensible.cpp
+++ b/src/extensible.cpp
@@ -142,7 +142,6 @@ void ExtensionItem::Sync(const Extensible* container, void* item)
 
 void ExtensionItem::FromInternal(Extensible* container, const std::string& value) noexcept
 {
-	FromNetwork(container, value);
 }
 
 void ExtensionItem::FromNetwork(Extensible* container, const std::string& value) noexcept
@@ -163,7 +162,7 @@ std::string ExtensionItem::ToHuman(const Extensible* container, void* item) cons
 
 std::string ExtensionItem::ToInternal(const Extensible* container, void* item) const noexcept
 {
-	return ToNetwork(container, item);
+	return {};
 }
 
 std::string ExtensionItem::ToNetwork(const Extensible* container, void* item) const noexcept
-- 
cgit v1.3.1-10-gc9f91