From 29705306f21d713c2928d8896f48a3cbb640eacc Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Thu, 29 Jun 2023 16:29:56 +0100 Subject: Retain the "real" username properly like we do for hostnames. This introduces the concept of a real username. This value comes from either the initial USER message or from an ident lookup. Doing this allows us to use it for bans through vidents and cloaking web client users using their remote username. While changing this I also changed all of the uses of "ident" other than RFC 1413 lookups and some compatibility cases to refer to usernames as user(name) instead of ident. Our use of ident in these places was incorrect as that only refers to the RFC 1413 response and is not commonly used in the way we used it by any other IRC server implementations. --- src/modules/m_spanningtree/netburst.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/modules/m_spanningtree/netburst.cpp') diff --git a/src/modules/m_spanningtree/netburst.cpp b/src/modules/m_spanningtree/netburst.cpp index 3f4d2defe..24ece4557 100644 --- a/src/modules/m_spanningtree/netburst.cpp +++ b/src/modules/m_spanningtree/netburst.cpp @@ -283,7 +283,7 @@ void TreeSocket::SendUsers(BurstState& bs) if (!user->IsFullyConnected()) continue; - this->WriteLine(CommandUID::Builder(user)); + this->WriteLine(CommandUID::Builder(user, this->proto_version != PROTO_INSPIRCD_3)); if (user->IsOper()) this->WriteLine(CommandOpertype::Builder(user, user->oper)); -- cgit v1.3.1-10-gc9f91