From 7e1f8466b76886591307daa539caaa8626c56cea Mon Sep 17 00:00:00 2001
From: Sadie Powell
Date: Mon, 10 Oct 2022 07:48:43 +0100
Subject: Fix serializing attributes in httpd_stats.

---
 src/modules/m_httpd_stats.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

(limited to 'src/modules')

diff --git a/src/modules/m_httpd_stats.cpp b/src/modules/m_httpd_stats.cpp
index 09d72cac5..8dc56972c 100644
--- a/src/modules/m_httpd_stats.cpp
+++ b/src/modules/m_httpd_stats.cpp
@@ -92,7 +92,10 @@ namespace Stats
 	public:
 		XMLSerializer& Attribute(const char* name, const std::string& value)
 		{
-			data << '<' << name << '>' << value << "</" << Sanitize(name) << '>';
+			if (value.empty())
+				data << '<' << name << "/>";
+			else
+				data << '<' << name << '>' << Sanitize(value) << "</" << name << '>';
 			return *this;
 		}
 
@@ -129,7 +132,7 @@ namespace Stats
 				.Attribute("name", item->name);
 
 			const std::string value = item->ToHuman(ext, obj);
-			serializer.Attribute("value", value.empty() ? value.c_str() : nullptr);
+			serializer.Attribute("value", value);
 		}
 		serializer.EndBlock();
 	}
-- 
cgit v1.3.1-10-gc9f91