From a982e710418275fee3ea8db6603c82de16182055 Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Tue, 10 Jan 2023 21:44:35 +0000 Subject: Fix some unnecessary string copies. --- src/modules/m_cap.cpp | 2 +- src/modules/m_sanick.cpp | 2 +- src/modules/m_sqloper.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/modules') diff --git a/src/modules/m_cap.cpp b/src/modules/m_cap.cpp index 7f9127f43..8df16e34f 100644 --- a/src/modules/m_cap.cpp +++ b/src/modules/m_cap.cpp @@ -367,7 +367,7 @@ private: Cap::ManagerImpl manager; ClientProtocol::EventProvider protoevprov; - void DisplayResult(LocalUser* user, const std::string& subcmd, std::vector result, bool asterisk) + void DisplayResult(LocalUser* user, const std::string& subcmd, const std::vector& result, bool asterisk) { size_t maxline = ServerInstance->Config->Limits.MaxLine - ServerInstance->Config->ServerName.size() - user->nick.length() - subcmd.length() - 11; std::string line; diff --git a/src/modules/m_sanick.cpp b/src/modules/m_sanick.cpp index 36d3ffe64..f7e4e5cb5 100644 --- a/src/modules/m_sanick.cpp +++ b/src/modules/m_sanick.cpp @@ -71,7 +71,7 @@ public: if (target && IS_LOCAL(target)) { const std::string oldnick = target->nick; - const std::string newnick = parameters[1]; + const std::string& newnick = parameters[1]; if (!ServerInstance->Users.FindNick(newnick) && target->ChangeNick(newnick)) { ServerInstance->SNO.WriteGlobalSno('a', user->nick + " used SANICK to change " + oldnick + " to " + newnick); diff --git a/src/modules/m_sqloper.cpp b/src/modules/m_sqloper.cpp index 85a9f7f6c..15b133eb1 100644 --- a/src/modules/m_sqloper.cpp +++ b/src/modules/m_sqloper.cpp @@ -221,7 +221,7 @@ public: { SQL->Submit(new OperQuery(this, my_blocks), query); } - void GetOperBlocks(const std::string u, const std::string& un, const std::string& pw) + void GetOperBlocks(const std::string& u, const std::string& un, const std::string& pw) { active = true; // Call to SQL query to fetch oper list from SQL table. -- cgit v1.3.1-10-gc9f91