From de2392833ec17a9deb865fdac0af73275fd960ff Mon Sep 17 00:00:00 2001
From: Sadie Powell
Date: Wed, 7 Sep 2022 21:09:09 +0100
Subject: Default allow_empty_last_param to false.

---
 src/modules/m_callerid.cpp                  | 1 -
 src/modules/m_chghost.cpp                   | 1 -
 src/modules/m_chgident.cpp                  | 1 -
 src/modules/m_chgname.cpp                   | 1 -
 src/modules/m_dccallow.cpp                  | 1 -
 src/modules/m_gateway.cpp                   | 2 --
 src/modules/m_globalload.cpp                | 3 ---
 src/modules/m_globops.cpp                   | 1 +
 src/modules/m_ircv3_ctctags.cpp             | 1 -
 src/modules/m_monitor.cpp                   | 1 -
 src/modules/m_rmode.cpp                     | 1 -
 src/modules/m_sajoin.cpp                    | 1 -
 src/modules/m_sakick.cpp                    | 1 +
 src/modules/m_samode.cpp                    | 1 -
 src/modules/m_sanick.cpp                    | 1 -
 src/modules/m_sapart.cpp                    | 1 +
 src/modules/m_sasl.cpp                      | 1 -
 src/modules/m_satopic.cpp                   | 1 +
 src/modules/m_sethost.cpp                   | 1 -
 src/modules/m_setident.cpp                  | 1 -
 src/modules/m_setname.cpp                   | 1 -
 src/modules/m_silence.cpp                   | 1 -
 src/modules/m_spanningtree/override_map.cpp | 1 -
 src/modules/m_sslinfo.cpp                   | 1 -
 src/modules/m_swhois.cpp                    | 1 +
 src/modules/m_topiclock.cpp                 | 1 +
 src/modules/m_watch.cpp                     | 1 -
 27 files changed, 6 insertions(+), 24 deletions(-)

(limited to 'src/modules')

diff --git a/src/modules/m_callerid.cpp b/src/modules/m_callerid.cpp
index ccc4c3f08..3503b3554 100644
--- a/src/modules/m_callerid.cpp
+++ b/src/modules/m_callerid.cpp
@@ -188,7 +188,6 @@ public:
 	CommandAccept(Module* Creator) : Command(Creator, "ACCEPT", 1),
 		extInfo(Creator)
 	{
-		allow_empty_last_param = false;
 		syntax = { "*|(+|-)<nick>[,(+|-)<nick>]+" };
 		translation = { TR_CUSTOM };
 	}
diff --git a/src/modules/m_chghost.cpp b/src/modules/m_chghost.cpp
index 25b4dbc9e..f857ca5cd 100644
--- a/src/modules/m_chghost.cpp
+++ b/src/modules/m_chghost.cpp
@@ -35,7 +35,6 @@ public:
 	CommandChghost(Module* Creator)
 		: Command(Creator,"CHGHOST", 2)
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<nick> <host>" };
 		translation = { TR_NICK, TR_TEXT };
diff --git a/src/modules/m_chgident.cpp b/src/modules/m_chgident.cpp
index 5fe6daf46..5f247b4ff 100644
--- a/src/modules/m_chgident.cpp
+++ b/src/modules/m_chgident.cpp
@@ -35,7 +35,6 @@ class CommandChgident final
 public:
 	CommandChgident(Module* Creator) : Command(Creator,"CHGIDENT", 2)
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<nick> <ident>" };
 		translation = { TR_NICK, TR_TEXT };
diff --git a/src/modules/m_chgname.cpp b/src/modules/m_chgname.cpp
index f9a311233..7448c8299 100644
--- a/src/modules/m_chgname.cpp
+++ b/src/modules/m_chgname.cpp
@@ -33,7 +33,6 @@ class CommandChgname final
 public:
 	CommandChgname(Module* Creator) : Command(Creator,"CHGNAME", 2, 2)
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<nick> :<realname>" };
 		translation = { TR_NICK, TR_TEXT };
diff --git a/src/modules/m_dccallow.cpp b/src/modules/m_dccallow.cpp
index 059c28761..c436f5b7d 100644
--- a/src/modules/m_dccallow.cpp
+++ b/src/modules/m_dccallow.cpp
@@ -194,7 +194,6 @@ public:
 		: Command(parent, "DCCALLOW", 0)
 		, ext(Ext)
 	{
-		allow_empty_last_param = false;
 		syntax = { "[(+|-)<nick> [<time>]]", "LIST", "HELP" };
 		/* XXX we need to fix this so it can work with translation stuff (i.e. move +- into a seperate param */
 	}
diff --git a/src/modules/m_gateway.cpp b/src/modules/m_gateway.cpp
index d4a9a3d7b..dbdc0cbf0 100644
--- a/src/modules/m_gateway.cpp
+++ b/src/modules/m_gateway.cpp
@@ -133,7 +133,6 @@ public:
 	CommandHexIP(Module* Creator)
 		: SplitCommand(Creator, "HEXIP", 1)
 	{
-		allow_empty_last_param = false;
 		Penalty = 2;
 		syntax = { "<hex-ip|raw-ip>" };
 	}
@@ -247,7 +246,6 @@ public:
 		, sslapi(Creator)
 		, webircevprov(Creator, "event/webirc")
 	{
-		allow_empty_last_param = false;
 		works_before_reg = true;
 		syntax = { "<password> <gateway> <hostname> <ip> [<flags>]" };
 	}
diff --git a/src/modules/m_globalload.cpp b/src/modules/m_globalload.cpp
index e1f5e7292..a40115df9 100644
--- a/src/modules/m_globalload.cpp
+++ b/src/modules/m_globalload.cpp
@@ -34,7 +34,6 @@ public:
 		: Command(Creator,"GLOADMODULE", 1)
 	{
 		access_needed = CmdAccess::OPERATOR;
-		allow_empty_last_param = false;
 		syntax = { "<modulename> [<servermask>]" };
 	}
 
@@ -74,7 +73,6 @@ public:
 		: Command(Creator,"GUNLOADMODULE", 1)
 	{
 		access_needed = CmdAccess::OPERATOR;
-		allow_empty_last_param = false;
 		syntax = { "<modulename> [<servermask>]" };
 	}
 
@@ -126,7 +124,6 @@ public:
 		: Command(Creator, "GRELOADMODULE", 1)
 	{
 		access_needed = CmdAccess::OPERATOR;
-		allow_empty_last_param = false;
 		syntax = { "<modulename> [<servermask>]" };
 	}
 
diff --git a/src/modules/m_globops.cpp b/src/modules/m_globops.cpp
index d34b1f931..760d41488 100644
--- a/src/modules/m_globops.cpp
+++ b/src/modules/m_globops.cpp
@@ -35,6 +35,7 @@ public:
 	CommandGlobops(Module* Creator) : Command(Creator,"GLOBOPS", 1,1)
 	{
 		access_needed = CmdAccess::OPERATOR;
+		allow_empty_last_param = true;
 		syntax = { ":<message>" };
 	}
 
diff --git a/src/modules/m_ircv3_ctctags.cpp b/src/modules/m_ircv3_ctctags.cpp
index d9ff1d3d3..4729c4b6c 100644
--- a/src/modules/m_ircv3_ctctags.cpp
+++ b/src/modules/m_ircv3_ctctags.cpp
@@ -215,7 +215,6 @@ public:
 		, tagevprov(Creator, "event/tagmsg")
 		, msgevprov(Creator, "TAGMSG")
 	{
-		allow_empty_last_param = false;
 	}
 
 	CmdResult Handle(User* user, const Params& parameters) override
diff --git a/src/modules/m_monitor.cpp b/src/modules/m_monitor.cpp
index 3ca8030f1..a97d0fefa 100644
--- a/src/modules/m_monitor.cpp
+++ b/src/modules/m_monitor.cpp
@@ -311,7 +311,6 @@ public:
 		, manager(managerref)
 	{
 		Penalty = 2;
-		allow_empty_last_param = false;
 		syntax = { "C", "L", "S", "(+|-) <nick>[,<nick>]+" };
 	}
 
diff --git a/src/modules/m_rmode.cpp b/src/modules/m_rmode.cpp
index 78d9ff4e2..d351becad 100644
--- a/src/modules/m_rmode.cpp
+++ b/src/modules/m_rmode.cpp
@@ -30,7 +30,6 @@ class CommandRMode final
 public:
 	CommandRMode(Module* Creator) : Command(Creator,"RMODE", 2, 3)
 	{
-		allow_empty_last_param = false;
 		syntax = { "<channel> <mode> [<pattern>]" };
 	}
 
diff --git a/src/modules/m_sajoin.cpp b/src/modules/m_sajoin.cpp
index 40cb14a81..3f710033d 100644
--- a/src/modules/m_sajoin.cpp
+++ b/src/modules/m_sajoin.cpp
@@ -38,7 +38,6 @@ public:
 		: Command(Creator,"SAJOIN", 1)
 		, servprotectmode(Creator, "servprotect")
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "[<nick>] <channel>[,<channel>]+" };
 		translation = { TR_NICK, TR_TEXT };
diff --git a/src/modules/m_sakick.cpp b/src/modules/m_sakick.cpp
index 7175d5ae2..28fd9c54a 100644
--- a/src/modules/m_sakick.cpp
+++ b/src/modules/m_sakick.cpp
@@ -36,6 +36,7 @@ public:
 		, servprotectmode(Creator, "servprotect")
 	{
 		access_needed = CmdAccess::OPERATOR;
+		allow_empty_last_param = true;
 		syntax = { "<channel> <nick> [:<reason>]" };
 		translation = { TR_TEXT, TR_NICK, TR_TEXT };
 	}
diff --git a/src/modules/m_samode.cpp b/src/modules/m_samode.cpp
index fd2ecb37f..5aadffb51 100644
--- a/src/modules/m_samode.cpp
+++ b/src/modules/m_samode.cpp
@@ -37,7 +37,6 @@ public:
 	bool active;
 	CommandSamode(Module* Creator) : Command(Creator,"SAMODE", 2)
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<target> (+|-)<modes> [<mode-parameters>]" };
 		active = false;
diff --git a/src/modules/m_sanick.cpp b/src/modules/m_sanick.cpp
index 466856008..8d1bd55d7 100644
--- a/src/modules/m_sanick.cpp
+++ b/src/modules/m_sanick.cpp
@@ -36,7 +36,6 @@ public:
 		: Command(Creator,"SANICK", 2)
 		, servprotectmode(Creator, "servprotect")
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<nick> <newnick>" };
 		translation = { TR_NICK, TR_TEXT };
diff --git a/src/modules/m_sapart.cpp b/src/modules/m_sapart.cpp
index 68399f794..629236240 100644
--- a/src/modules/m_sapart.cpp
+++ b/src/modules/m_sapart.cpp
@@ -37,6 +37,7 @@ public:
 		, servprotectmode(Creator, "servprotect")
 	{
 		access_needed = CmdAccess::OPERATOR;
+		allow_empty_last_param = true;
 		syntax = { "<nick> <channel>[,<channel>]+ [:<reason>]" };
 		translation = { TR_NICK, TR_TEXT, TR_TEXT };
 	}
diff --git a/src/modules/m_sasl.cpp b/src/modules/m_sasl.cpp
index 48cd996f2..442a40e6b 100644
--- a/src/modules/m_sasl.cpp
+++ b/src/modules/m_sasl.cpp
@@ -330,7 +330,6 @@ public:
 		, sslapi(Creator)
 	{
 		works_before_reg = true;
-		allow_empty_last_param = false;
 	}
 
 	CmdResult HandleLocal(LocalUser* user, const Params& parameters) override
diff --git a/src/modules/m_satopic.cpp b/src/modules/m_satopic.cpp
index a52a784d3..450b332eb 100644
--- a/src/modules/m_satopic.cpp
+++ b/src/modules/m_satopic.cpp
@@ -34,6 +34,7 @@ public:
 	CommandSATopic(Module* Creator) : Command(Creator,"SATOPIC", 2, 2)
 	{
 		access_needed = CmdAccess::OPERATOR;
+		allow_empty_last_param = true;
 		syntax = { "<channel> :<topic>" };
 	}
 
diff --git a/src/modules/m_sethost.cpp b/src/modules/m_sethost.cpp
index e678cb3a3..dac4fdae7 100644
--- a/src/modules/m_sethost.cpp
+++ b/src/modules/m_sethost.cpp
@@ -34,7 +34,6 @@ public:
 	CommandSethost(Module* Creator)
 		: Command(Creator,"SETHOST", 1)
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<host>" };
 	}
diff --git a/src/modules/m_setident.cpp b/src/modules/m_setident.cpp
index a8d89cc89..f9013718a 100644
--- a/src/modules/m_setident.cpp
+++ b/src/modules/m_setident.cpp
@@ -33,7 +33,6 @@ class CommandSetident final
 public:
  CommandSetident(Module* Creator) : Command(Creator,"SETIDENT", 1)
 	{
-		allow_empty_last_param = false;
 		access_needed = CmdAccess::OPERATOR;
 		syntax = { "<ident>" };
 	}
diff --git a/src/modules/m_setname.cpp b/src/modules/m_setname.cpp
index e2649aace..e94f425f0 100644
--- a/src/modules/m_setname.cpp
+++ b/src/modules/m_setname.cpp
@@ -42,7 +42,6 @@ public:
 		, fail(Creator)
 		, cap(Creator, "setname")
 	{
-		allow_empty_last_param = false;
 		syntax = { ":<realname>" };
 	}
 
diff --git a/src/modules/m_silence.cpp b/src/modules/m_silence.cpp
index 5802a768d..d2d989cc7 100644
--- a/src/modules/m_silence.cpp
+++ b/src/modules/m_silence.cpp
@@ -351,7 +351,6 @@ public:
 		, msgprov(Creator, "SILENCE")
 		, ext(Creator)
 	{
-		allow_empty_last_param = false;
 		syntax = { "[(+|-)<mask> [CcdiNnPpTtx]]" };
 	}
 
diff --git a/src/modules/m_spanningtree/override_map.cpp b/src/modules/m_spanningtree/override_map.cpp
index 0abd3634c..1df272e41 100644
--- a/src/modules/m_spanningtree/override_map.cpp
+++ b/src/modules/m_spanningtree/override_map.cpp
@@ -37,7 +37,6 @@
 CommandMap::CommandMap(Module* Creator)
 	: Command(Creator, "MAP", 0, 1)
 {
-	allow_empty_last_param = false;
 	Penalty = 2;
 }
 
diff --git a/src/modules/m_sslinfo.cpp b/src/modules/m_sslinfo.cpp
index dd054cbf0..c65f119e6 100644
--- a/src/modules/m_sslinfo.cpp
+++ b/src/modules/m_sslinfo.cpp
@@ -255,7 +255,6 @@ public:
 		, sslonlymode(Creator, "sslonly")
 		, sslapi(Creator)
 	{
-		allow_empty_last_param = false;
 		syntax = { "<channel|nick>" };
 	}
 
diff --git a/src/modules/m_swhois.cpp b/src/modules/m_swhois.cpp
index 89d5f2d76..e19252911 100644
--- a/src/modules/m_swhois.cpp
+++ b/src/modules/m_swhois.cpp
@@ -40,6 +40,7 @@ public:
 		, swhois(Creator, "swhois", ExtensionType::USER, true)
 	{
 		access_needed = CmdAccess::OPERATOR;
+		allow_empty_last_param = true;
 		syntax = { "<nick> :<swhois>" };
 		translation = { TR_NICK, TR_TEXT };
 	}
diff --git a/src/modules/m_topiclock.cpp b/src/modules/m_topiclock.cpp
index 744e63ddb..d27dc7866 100644
--- a/src/modules/m_topiclock.cpp
+++ b/src/modules/m_topiclock.cpp
@@ -33,6 +33,7 @@ public:
 		: Command(Creator, "SVSTOPIC", 1, 4)
 	{
 		access_needed = CmdAccess::SERVER;
+		allow_empty_last_param = true;
 	}
 
 	CmdResult Handle(User* user, const Params& parameters) override
diff --git a/src/modules/m_watch.cpp b/src/modules/m_watch.cpp
index e16588233..43331eb20 100644
--- a/src/modules/m_watch.cpp
+++ b/src/modules/m_watch.cpp
@@ -129,7 +129,6 @@ public:
 		: SplitCommand(mod, "WATCH")
 		, manager(managerref)
 	{
-		allow_empty_last_param = false;
 		syntax = { "C", "L", "l", "S", "(+|-)<nick> [(+|-)<nick>]+" };
 	}
 
-- 
cgit v1.3.1-10-gc9f91