From d1301063741b3544342e10fcc02f72417000b50e Mon Sep 17 00:00:00 2001
From: Sadie Powell
Date: Thu, 1 Dec 2022 05:39:24 +0000
Subject: Avoid copying a shared_ptr where not actually necessary.

---
 src/users.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

(limited to 'src/users.cpp')

diff --git a/src/users.cpp b/src/users.cpp
index fad22e7e3..f700a7659 100644
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -430,8 +430,7 @@ void User::OperLogout()
  */
 void LocalUser::CheckClass(bool clone_count)
 {
-	ConnectClass::Ptr a = GetClass();
-
+	const ConnectClass::Ptr& a = GetClass();
 	if (!a)
 	{
 		ServerInstance->Users.QuitUser(this, "Access denied by configuration");
@@ -1164,7 +1163,7 @@ ConnectClass::ConnectClass(std::shared_ptr<ConfigTag> tag, Type t, const std::ve
 {
 }
 
-ConnectClass::ConnectClass(std::shared_ptr<ConfigTag> tag, Type t, const std::vector<std::string>& masks, ConnectClass::Ptr parent)
+ConnectClass::ConnectClass(std::shared_ptr<ConfigTag> tag, Type t, const std::vector<std::string>& masks, const ConnectClass::Ptr& parent)
 {
 	Update(parent);
 	name = "unnamed";
@@ -1226,7 +1225,7 @@ void ConnectClass::Configure(const std::string& classname, std::shared_ptr<Confi
 	uniqueusername = tag->getBool("uniqueusername", uniqueusername);
 }
 
-void ConnectClass::Update(const ConnectClass::Ptr src)
+void ConnectClass::Update(const ConnectClass::Ptr& src)
 {
 	ServerInstance->Logs.Debug("CONNECTCLASS", "Updating %s from %s", name.c_str(), src->name.c_str());
 	commandrate = src->commandrate;
-- 
cgit v1.3.1-10-gc9f91